samldb_user_account_control_change

[Matthias Dieter Wallnöfer]

Hi ekacnet,

regarding 
http://git.samba.org/?p=mat/samba.git;a=commitdiff;h=3cfdedd9d6a4be8f229d0030900f808289effe29: 
please don't sort out these things since the plan is to end up in common 
LDB add and modify triggers code at some point.

Second question: is the sam.py code still passing with your second change?

Cheers,
Matthias

Matthieu Patou wrote:
> Hello Mathias,
>
> I faced some strange behavior with net setpassword and I'm pretty sure 
> that's it's linked to samldb_user_account_control_change.
>
> Are you sure that this function should be called on modify ? At least 
> I'm sure that primaryGroupID should not be set.
>
> I made a try with a user with primaryGroupID set to 513, I locked the 
> user, when I unlock the user, Windows XP sends to a W2k8R2 DC a modify 
> on userAccountControl but this didn't imply modifying the primaryGroupID.
>
> I have the feeling that the group calculation should be done only on 
> add not on modify.
>
> So I pushed 2 patches here:
>
> http://git.samba.org/?p=mat/samba.git;a=shortlog;h=refs/heads/miscsamdb
>
> Matthieu.
>