pidl/wscript: only warn about grammar file changes

Andrew Bartlett abartlet at samba.org
Mon Jan 17 20:25:13 MST 2011


On Tue, 2011-01-11 at 23:51 +1100, tridge at samba.org wrote:
> Hi Metze,
> 
>  > 	$ touch ../pidl/lib/Parse/Pidl/IDL.pm ../pidl/lib/Parse/Pidl/Expr.pm
>  > 
>  > What's so hard about just calling this?
> 
> it is confusing, as the user thinks they have done something wrong.
> 
> I'd prefer just not to have this check, but if you really want to have
> it, then I think we could do it like this:
> 
>  1) use the timestamp as you do now to see if the files might have
>  changed
> 
>  2) if they might have changed, then use git log/diff to see if they
>  really have changed, and only show the warning if they really have
>  changed

Metze,

Can you please revert this back to not checking.  The message is both
annoying and meaningless to the vast majority of users developers, and
as you say in your commit, autobuild will catch if one of the few who do
change pidl grammar files fails to check it in. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.



More information about the samba-technical mailing list