[TDB] Patches for file and memory usage growth issues

Rusty Russell rusty at samba.org
Tue Apr 12 23:16:03 MDT 2011


On Wed, 13 Apr 2011 11:22:33 +0930, Rusty Russell <rusty at samba.org> wrote:
> I'll test that now and give you a fresh tree, sorry!

OK, this time for sure!

http://git.samba.org/?p=rusty/samba.git;a=shortlog;h=refs/heads/tdb-repack

Now, the final patch might be a bad idea, so I've separated it out.
It's probably what's making things slow, so I'd test without it first.

I haven't merged your expand size logic patch yet, so feel free to
push that to master whenever you want.

The following changes since commit af45636166c7a0cb87630105d18ce489e7391525:

  Fix bug 8072 - PANIC: create_file_acl_common frees handle two times. (2011-04-09 02:05:15 +0200)

are available in the git repository at:
  git://git.samba.org/rusty/samba.git tdb-repack

Rusty Russell (4):
      tdb: fix transaction recovery area for converted tdbs.
      tdb: tdb_repack() only when it's worthwhile.
      tdb: tdb_repack in place.
      tdb: strip unused padding when repacking.

 lib/tdb/common/freelist.c    |   14 ++--
 lib/tdb/common/repack.c      |  215 ++++++++++++++++++++++++++++++++++++++++++
 lib/tdb/common/tdb.c         |   91 ------------------
 lib/tdb/common/tdb_private.h |    6 +
 lib/tdb/common/transaction.c |   87 +++++++++++++-----
 lib/tdb/libtdb.m4            |    2 +-
 lib/tdb/wscript              |    2 +-
 7 files changed, 294 insertions(+), 123 deletions(-)
 create mode 100644 lib/tdb/common/repack.c


More information about the samba-technical mailing list