[TDB] Patches for file and memory usage growth issues
rusty at samba.org
Tue Apr 12 19:52:33 MDT 2011
On Tue, 12 Apr 2011 11:16:58 -0400, simo <idra at samba.org> wrote:
> On Tue, 2011-04-12 at 10:57 -0400, simo wrote:
> > On Tue, 2011-04-12 at 09:01 -0400, simo wrote:
> > >
> > > I added a tdb_locakall() and a final f[data]sync() on tdb_fd().
> > >
> > > See:
> > > http://git.samba.org/?p=idra/samba.git;a=commitdiff;h=54ac2dd19b9187089d2ee86a226f65f634bf660a
> > Please ignore this one, apparently tdbbackup is failing with this patch
> > now.
> Actually, it turns out that tdbbackup works just fine with this patch
> once I remove Rusty's patches and run it on TDBs created without Rusty's
> patches. So please review it and ack/nack.
> Rusty, apparently your patches are also causing TDB database corruption.
Oops, I know. I found that bug in testing, and then forgot to push. Sorry!
Meanwhile, Tridge suggested that we do the logical thing and figure out
repacking is worthwhile before we do it: if the sum of free fragments
is greater than the largest fragment, it's probably worth repacking.
I'll test that now and give you a fresh tree, sorry!
More information about the samba-technical