dns.idl ==> build breaks on non-ipv6 systems

[David Holder]

I agree. I think that the long term solution is to write protocol 
independent code; using the IPv6 socket API. Then for platforms without 
(modern or any) IPv6 API support use libreplace to provide the missing 
functions.

This is what Jeremy did for Samba 3.

David
------------------------------------------------------------------------
Dr David Holder CEng FIET MIEEE

Erion Ltd, Oakleigh, Upper Sutherland Road, Halifax, HX3 8NT

Reception: +44 (0)1422 207000

Direct Dial: +44 (0)131 2026317

Cell: +44 (0) 7768 456831
Web:http://www.erion.co.uk

Registered in England and Wales. Registered Number 3521142
VAT Number: GB 698 3633 78



On 08/11/2010 12:02, Stefan (metze) Metzmacher wrote:
> Am 07.11.2010 10:16, schrieb Kai Blin:
>> On 2010-11-07 09:58, Kai Blin wrote:
>>
>> Hi Michael,
>>
>>>> it seems the introduction of the dns server in s4
>>>> has broken the build on non-ipv6 systems by using
>>>> AD_INET6 unconditionally in the pull/push/print_ipv6
>>>> functions in ndr_basic.c
>>> It's not directly related to the dns server, but I agree I did forget to
>>> put some IPv6 #ifdef around it. In fact, I also got a couple of things
>>> wrong that David pointed out. I'll go and properly fix this.
>> In the meantime, I think the attached patch should fix the build on your
>> non-IPv6 hosts.
> I'm not sure if that would fix the build.
>
> I think we should add the #ifdef in the function and return an error,
> that should fix the build for now.
>
> But for Samba4 we need a real solution, and implement the ndr_pull/push
> function
> without relying on the kernel/libc to support ipv6.
>
> metze
>