dns.idl ==> build breaks on non-ipv6 systems

[Michael Adam]

Hi Kai,

Kai Blin wrote:
> On 2010-11-06 03:05, Michael Adam wrote:
> 
> Hi Michael,
> 
> > it seems the introduction of the dns server in s4
> > has broken the build on non-ipv6 systems by using
> > AD_INET6 unconditionally in the pull/push/print_ipv6
> > functions in ndr_basic.c
> 
> It's not directly related to the dns server, but I agree I did forget to
> put some IPv6 #ifdef around it. In fact, I also got a couple of things
> wrong that David pointed out. I'll go and properly fix this.

Ok, that's great.

> > Since these functions are in ndr_basic.c this also
> > breaks the build of s3 on non-ipv6-systems.
> 
> I don't have a system that doesn't have IPv6 support. Is there a box on
> the build farm that I can use to check I got the fix right?

Yep, for instance hape:
http://build.samba.org/?function=View+Build;host=hape;tree=samba_3_master;compiler=gcc
This our HP-UX machine, I could arrange remote access for you.

> > Attached find a patch that moves these 3 functions
> > to a new module ndr_ipv6.c that is only used in s4.
> 
> I don't know if I like the solution. My plans for the DNS part is to
> replace libaddns with an async dns client library that uses dns.idl.
> As the IPv6 address is implemented as a basic datatype in PIDL, just the
> way IPv4 addresses are, I'd argue the parser code for this into ndr_basic.c

Ok, ok...

My argument was also rather that the addresse are not so basic
data types after all and deserve their own module. Maybe we
should remove the ip4 functions from ndr_basic as well... ;-)

But since it seems to be very important for everyone that they
belong into ndr_basic, I will shut up regarding moving them
out... :-D

Cheers - Michael

> Cheers,
> Kai
> 
> -- 
> Kai Blin
> Worldforge developer http://www.worldforge.org/
> Wine developer http://wiki.winehq.org/KaiBlin
> Samba team member http://www.samba.org/samba/team/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101107/dc196daf/attachment.pgp>