dns.idl ==> build breaks on non-ipv6 systems
Stefan (metze) Metzmacher
metze at samba.org
Mon Nov 8 05:02:43 MST 2010
Am 07.11.2010 10:16, schrieb Kai Blin:
> On 2010-11-07 09:58, Kai Blin wrote:
> Hi Michael,
>>> it seems the introduction of the dns server in s4
>>> has broken the build on non-ipv6 systems by using
>>> AD_INET6 unconditionally in the pull/push/print_ipv6
>>> functions in ndr_basic.c
>> It's not directly related to the dns server, but I agree I did forget to
>> put some IPv6 #ifdef around it. In fact, I also got a couple of things
>> wrong that David pointed out. I'll go and properly fix this.
> In the meantime, I think the attached patch should fix the build on your
> non-IPv6 hosts.
I'm not sure if that would fix the build.
I think we should add the #ifdef in the function and return an error,
that should fix the build for now.
But for Samba4 we need a real solution, and implement the ndr_pull/push
without relying on the kernel/libc to support ipv6.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 262 bytes
Desc: OpenPGP digital signature
More information about the samba-technical