[PATCH] Change DOM_SID to struct dom_sid, and use C99 types in passdb

[Andrew Bartlett]

On Fri, 2010-05-21 at 07:48 -0400, simo wrote:
> On Fri, 2010-05-21 at 13:52 +1000, Andrew Bartlett wrote:
> > Guenther,
> > 
> > As we discussed on IRC, I'm looking to try and provide a passdb module
> > that links directly onto the sam.ldb database, and so I've been looking
> > at what would prevent the source3 passdb.h header file from being in
> > common.
> > 
> > These patches address the two issues that stood out at first - are the
> > fact that it uses DOM_SID and uint16 etc (rather than uint16_t).
> > 
> > http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/master-with-typedef-changes
> > ie, master-with-typedef-changes in my git repo.  I can also send them to
> > the list if desired (but as a simple rename, they are very large). 
> > 
> > They pass 'make selftest' with the same failures as an unpatched master
> > tree.
> 
> Andrew,
> why not using a simple define in the header file ?

The reason I did the cleanup, rather than the simple compatibility
change is that we do really want to migrate to the C99 types
eventually. 

> this huge patch just to append a '_t' to every variable definition seem
> really invasive for no good reason.

We currently have a lot of code using both conventions.  We need to
follow up our now years-ago decision to switch to C99 types with actual
patches.  This is my small contribution to this task.  Hopefully some
day we will consistently follow the new conventions.  

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100522/9a48874d/attachment.pgp>