[PATCH] Change DOM_SID to struct dom_sid, and use C99 types in passdb

Jeremy Allison jra at samba.org
Sun May 23 18:55:06 MDT 2010


On Sat, May 22, 2010 at 08:01:17PM +1000, Andrew Bartlett wrote:
> 
> The reason I did the cleanup, rather than the simple compatibility
> change is that we do really want to migrate to the C99 types
> eventually. 
> 
> > this huge patch just to append a '_t' to every variable definition seem
> > really invasive for no good reason.
> 
> We currently have a lot of code using both conventions.  We need to
> follow up our now years-ago decision to switch to C99 types with actual
> patches.  This is my small contribution to this task.  Hopefully some
> day we will consistently follow the new conventions.  

+1 from me. Every patch that moves the source3 code to using
C99 types gets us closer to common code. Thanks for doing the
fix Andrew.

Jeremy.


More information about the samba-technical mailing list