[PATCH] Change DOM_SID to struct dom_sid, and use C99 types in passdb

[simo]

On Fri, 2010-05-21 at 13:52 +1000, Andrew Bartlett wrote:
> Guenther,
> 
> As we discussed on IRC, I'm looking to try and provide a passdb module
> that links directly onto the sam.ldb database, and so I've been looking
> at what would prevent the source3 passdb.h header file from being in
> common.
> 
> These patches address the two issues that stood out at first - are the
> fact that it uses DOM_SID and uint16 etc (rather than uint16_t).
> 
> http://gitweb.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/master-with-typedef-changes
> ie, master-with-typedef-changes in my git repo.  I can also send them to
> the list if desired (but as a simple rename, they are very large). 
> 
> They pass 'make selftest' with the same failures as an unpatched master
> tree.

Andrew,
why not using a simple define in the header file ?

this huge patch just to append a '_t' to every variable definition seem
really invasive for no good reason.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>