Make -k a simple non-bool option.

[Andrew Bartlett]

On Thu, 2010-05-20 at 17:16 -0500, Jeremy Allison wrote:
> The branch, master has been updated
>        via  2bbf055... Make -k a simple non-bool option.
>        via  2d46e07... Fix what looks like a cut-and-paste error in our read_negTokenInit() function.
>       from  8a4525d... waf: fix the build of nsswitch libwbclient.
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 2bbf055dbb15ea99b80ae66adc906ad5494a3999
> Author: Jeremy Allison <jra at samba.org>
> Date:   Thu May 20 14:59:34 2010 -0700
> 
>     Make -k a simple non-bool option.
>     
>     Jeremy.

Jeremy,

Given that this patch breaks 'make test', was it so urgent that it could
not have been put in a branch until I looked at it?  

Please revert it until we work out a new set of options and fix all the
scripts. 

> commit 2d46e07c47418fdec5239d65032277c7917a44a4
> Author: Jeremy Allison <jra at samba.org>
> Date:   Thu May 20 14:30:44 2010 -0700
> 
>     Fix what looks like a cut-and-paste error in our read_negTokenInit() function.
>     
>     We should never be calling asn1_push_XXX functions inside an asn1
>     reading function. Change asn1_push_tag() -> asn1_start_tag() and
>     asn1_pop_tag() -> asn1_end_tag(). This allows us to connect to a
>     NetApp filer at the Microsoft plugfest.
>     
>     Andrew PLEASE CHECK !
>     
>     Jeremy.

Similarly, while this may be correct, if you think I need to check
something, please put it past me before you push it.  Put it in a
private git tree if need be. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100521/5dbf4fc9/attachment.pgp>