Fix what looks like a cut-and-paste error in our read_negTokenInit() function.
abartlet at samba.org
Thu May 20 23:25:17 MDT 2010
On Fri, 2010-05-21 at 12:05 +1000, Andrew Bartlett wrote:
> > commit 2d46e07c47418fdec5239d65032277c7917a44a4
> > Author: Jeremy Allison <jra at samba.org>
> > Date: Thu May 20 14:30:44 2010 -0700
> > Fix what looks like a cut-and-paste error in our read_negTokenInit() function.
> > We should never be calling asn1_push_XXX functions inside an asn1
> > reading function. Change asn1_push_tag() -> asn1_start_tag() and
> > asn1_pop_tag() -> asn1_end_tag(). This allows us to connect to a
> > NetApp filer at the Microsoft plugfest.
> > Andrew PLEASE CHECK !
> > Jeremy.
> Similarly, while this may be correct, if you think I need to check
> something, please put it past me before you push it. Put it in a
> private git tree if need be.
I've now checked the functions being called here, and I agree, this
looks like a cut-and-paste error from quite a while ago.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 190 bytes
Desc: This is a digitally signed message part
More information about the samba-technical