s4: Some patches to make the build work on older linux distributions
Stefan (metze) Metzmacher
metze at samba.org
Thu Feb 4 09:02:14 MST 2010
Jelmer Vernooij schrieb:
> Hi Matthias,
> On Sat, 2010-01-30 at 15:33 +0100, Matthias Dieter Wallnöfer wrote:
>> Recently I tested the build of s4 on a CentOS4 installation. The
>> following two patches I had to apply to make the build work.
>> As stated in the commit comments the behaviour on newer distributions
>> shouldn't break. Do you think that it's okay to apply this patches?
> I'm a bit hesitant to +1 this without understanding why these changes
> are necessary on CentOS4 but not on other distributions - these
> functions are pretty basic and will be present in any Linux distro, no
> matter how old.
> Metze wrote nss_wrapper IIRC. Metze, any chance you could have a look.
I think both patches are not ok.
- ALWAYS include replace.h or includes.h as first header
otherwise we'll break older systems.
- I think we should try to not include uid_wrapper.h in heimdal_build/
- And also not in includes/includes.h
- I think we should only include it in source4/ntvfs/unixid/ and
lib/util/unix_privs.c (if it doesn't break make test).
And then #include "system/passwd.h" should be included in both
C files instead of in uid_wrapper.h
- I think the nsstest part is ok
- The heimdal part needs to be fixed by defining NSS_WRAPPER_DISABLE
in heimdal_build/roken.h, we nees NSS_WRAPPER_DISABLE in the same
way we have SOCKET_WRAPPER_DISABLE
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 260 bytes
Desc: OpenPGP digital signature
More information about the samba-technical