s4: Some patches to make the build work on older linux distributions
Matthias Dieter Wallnöfer
mdw at samba.org
Thu Feb 4 13:11:44 MST 2010
Stefan (metze) Metzmacher wrote:
> I think both patches are not ok.
> - ALWAYS include replace.h or includes.h as first header
> otherwise we'll break older systems.
> - I think we should try to not include uid_wrapper.h in heimdal_build/
> - And also not in includes/includes.h
> - I think we should only include it in source4/ntvfs/unixid/ and
> lib/util/unix_privs.c (if it doesn't break make test).
> And then #include "system/passwd.h" should be included in both
> C files instead of in uid_wrapper.h
I've attached a new patch version which should contain all your suggestions.
> - I think the nsstest part is ok
> - The heimdal part needs to be fixed by defining NSS_WRAPPER_DISABLE
> in heimdal_build/roken.h, we nees NSS_WRAPPER_DISABLE in the same
> way we have SOCKET_WRAPPER_DISABLE
metze, I don't find this SOCKET_WRAPPER_DISABLE symbol - only a
SOCKET_WRAPPER_REPLACE one. Please describe this a bit more so I know
better how to fix this. Or if you would like to fix this heimdal part on
your own (probably you know better how than I do) I'm also fine. Then I
truncate my patch to contain only the "nsstest" part.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4473 bytes
Desc: not available
More information about the samba-technical