werror.h enriched with few more error code (DRSUAPI related)

Andrew Bartlett abartlet at samba.org
Mon Sep 14 13:54:46 MDT 2009

On Sun, 2009-09-13 at 04:26 +0300, Kamen Mazdrashki wrote:
> Here it goes again...
> Version 0.2 of the 'win32 error code parsers' script.
> This time with some extensions and a patch for werror.h and doserr.c files.
> It took more than 2 times the time I've expected for scripting but...
> I think it worth it every hour spent :)
> The patch become way to big but... there a lots of error codes.
> Additions to the script:
> - command line options and help (thanks to optparse module)
> - works in two modes
>   - 'generate' - generates file chunks to be copy/pasted
>     -- support online and offline mode for html file to be parsed
>     -- output dir for generating files
>   - 'clean' - clean up werror.h and doserr.c files from error codes that are about to be pasted

So, I've talked to Jermey and Guenther about what would be required to
merge these changes.

In short, we need to first have a patch that first converts all the
existing incorrect error codes to the new correct names.  This patch
should not change the values, or the value formats.  But do add an alias
for WERR_OK to WERR_SUCCESS (as otherwise the patch will be too large). 

Then, once everything uses the new names, then provide a patch to use
the automated table, in decimal.  We can see that the change (perhaps on
sorted files) is additions only.  We can then write a quick C program to
dump the error table and the hex values, and again show that the change
is additions only.  Finally, we can import as hex values (knowing that
we only changed the script to print hex not decimal). 

I know this is a *lot* of work, but otherwise the potential for errors
is too large to accept the patch.

GD also had a patch to do this once, and may have other hints or things
to consider. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090914/f19ddc6e/attachment.pgp>

More information about the samba-technical mailing list