Remaining "cast"/"const" patches
Matthias Dieter Wallnöfer
mdw at samba.org
Sun Oct 18 13:43:55 MDT 2009
for sure: http://repo.or.cz/w/Samba/mdw.git?a=shortlog;h=refs/heads/const
--- Jelmer Vernooij <jelmer at vernstok.nl> schrieb am So, 18.10.2009:
Von: Jelmer Vernooij <jelmer at vernstok.nl>
Betreff: Re: Remaining "cast"/"const" patches
An: mdw at samba.org
CC: "Andrew Bartlett" <abartlet at samba.org>, "Samba Technical Mailinglist" <samba-technical at lists.samba.org>
Datum: Sonntag, 18. Oktober 2009, 19:27
On Sun, 2009-10-18 at 16:25 +0000, Matthias Dieter Wallnöfer wrote:
> I finished the split-up. It's not reasonable to post the patches as attachment - so they're only in my private repo. Maybe you like to write the filenames or patch titles of those which look okay.
Do you have a link to your private repository handy? It doesn't seem to
be on git.samba.org at least...
> --- Matthias Dieter Wallnöfer <mdw at samba.org> schrieb am Fr, 16.10.2009:
> Von: Matthias Dieter Wallnöfer <mdw at samba.org>
> Betreff: Re: Remaining "cast"/"const" patches
> An: "Andrew Bartlett" <abartlet at samba.org>
> CC: "Samba Technical Mailinglist" <samba-technical at lists.samba.org>
> Datum: Freitag, 16. Oktober 2009, 12:32
> well - okay - I'll definitely split them up. I see it's too much work in one commit.
> --- Andrew Bartlett <abartlet at samba.org> schrieb am Fr, 16.10.2009:
> For as long as you continue to post these as large 'fix things' patches,
> we will have to continue to reject them. I'm sorry it has to be this
> way, and I know it is a *lot* of work to split up the patches, but it is
> even more work to track down problems later, and Volker is right to be
> concerned when there are behaviour changes mixed in with casts.
> You even just have other stylistic changes mixed in with these patches.
> A change such as the one to nbtname might be correct, but it is also a
> great example of why it needs to be separated, so it can be clearly
> explained in it's own commit message, and clearly understood independent
> from other changes. This same need applies to almost every change in
> this series.
> Perhaps you don't know how to use 'git add -i' to create small patches
> from one file? (A git guru on #samba-technical will no doubt be glad to
> give you a tutorial).
> Andrew Bartlett
More information about the samba-technical