s4: "lp_workgroup()" vs. "lp_sam_name()"

[Andrew Bartlett]

On Sun, 2009-10-18 at 16:46 +0000, Matthias Dieter Wallnöfer wrote:
> Hi Andrews,
> 
> as I found out there exist two loadparm functions which perform nearly
> the same operation: "lp_workgroup()" returns always the workgroup or
> short domainnameand "lp_sam_name()" does this only when we are a DC.
> Otherwise it returns the "local (user-) domain" - the netbios name of
> our box. If we are a DC - all is okay. The difference we've only on
> standalone and member boxes.
> 
> There are more than 100 calls to those functions. Since I didn't find
> out which are the exact rules when to call the first - and when the
> latter we should do some better check since I doubt that all
> invocations are okay. So we should do also here a cleanup (like with
> the realm and DNS domainname).
> 
> But here I really have no idea where the first call fits and where the
> second. Do you both (or also others) know about some rules? E.g. "on
> this pipe use always the first" or "the auth system should use always
> the second variant".
> 
> I need this also in one case for the password hash module (it has a
> "lp_workgroup" call at the moment but also here I don't know if it
> fits).

For the password hash, it should be lp_sam_name(), but it does not
matter, as member server and standalone installations don't use the
extra password hash formats that use this value.

Given we have both forms, you should generally assume they have been
chosen correctly, or it does not matter (such as functions only ever
exposed on a DC). 

If you think something is incorrect, write a test, and run it against a
standalone and DC copy of windows, then include it in our 'make test'.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091019/8908d821/attachment.pgp>