s4:torture "cldap" test - rework and test more results

[Andrew Bartlett]

On Sun, 2009-10-18 at 07:48 -0500, Matthias Dieter Wallnöfer wrote:
> The branch, master has been updated
>        via  77b9d28... s4:torture "cldap" test - rework and test more results
>        via  85e4995... s4:sites - get the server site (name) from DSDB
>        via  5d4093a... s4:dcerpc_netlogon - unify the two workstation object lookups (DNS hostname and supported encryption types)
>       from  56a8baf... s4:ldb_msg - Use LDB constants on results
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 77b9d2827b296d8da69545b647acae1c2de8717d
> Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
> Date:   Sun Oct 18 14:30:50 2009 +0200
> 
>     s4:torture "cldap" test - rework and test more results

> @@ -236,11 +222,21 @@ static bool test_cldap_netlogon(struct torture_context *tctx, const char *dest)
>  	search.in.realm = n1.data.nt5_ex.dns_domain;
>  	status = cldap_netlogon(cldap, iconv_convenience, tctx, &search);
>  	CHECK_STATUS(status, NT_STATUS_OK);
> -	CHECK_STRING(search.out.netlogon.data.nt5_ex.forest, n1.data.nt5_ex.dns_domain);
> -	CHECK_STRING(search.out.netlogon.data.nt5_ex.dns_domain, n1.data.nt5_ex.dns_domain);
>  	CHECK_STRING(search.out.netlogon.data.nt5_ex.user_name, "");
>  	CHECK_VAL(search.out.netlogon.data.nt5_ex.command, LOGON_SAM_LOGON_RESPONSE_EX);

Why remove the tests?  It would seem important to me to check how and
incorrect domain influences these results. 

(Adding more tests is of course reasonable)

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091019/8f6238fb/attachment.pgp>