[PATCH] pass smb_tcon to ntvfs_connect and use ntvfs_map_connect()

Stefan (metze) Metzmacher metze at samba.org
Fri May 8 14:40:18 GMT 2009


Sam Liddicott schrieb:
> * Stefan (metze) Metzmacher wrote, On 08/05/09 15:14:
>> Sam Liddicott schrieb:
>>   
>>> Here's a first cut, applies to the previous patch.
>>>
>>> I don't like the ntvfs_map_connect technique, I'm trying the alternative
>>> which requires many of the vfs *_connect functions doing their own tcon
>>> level checking, though...
>>>     
>> I think we should not add a generic level for tcon.
>>
>> We should just have switch statements in each of the connect functions.
>>
>> And please use 'tcon' instead of 'con' as variable name:-)
>>   
> Hows this sample for vfs_cifs?
> 
> The bottom fragment is illustrative, this specific file probably won't
> need a case statement as the RAW_TCON_TCON max xmit was already filled
> in by reply.c

looks ok

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090508/ee62d47a/signature.bin


More information about the samba-technical mailing list