[PATCH] pass smb_tcon to ntvfs_connect and use ntvfs_map_connect()

Sam Liddicott sam at liddicott.com
Fri May 8 14:36:24 GMT 2009


* Stefan (metze) Metzmacher wrote, On 08/05/09 15:14:
> Sam Liddicott schrieb:
>   
>> Here's a first cut, applies to the previous patch.
>>
>> I don't like the ntvfs_map_connect technique, I'm trying the alternative
>> which requires many of the vfs *_connect functions doing their own tcon
>> level checking, though...
>>     
>
> I think we should not add a generic level for tcon.
>
> We should just have switch statements in each of the connect functions.
>
> And please use 'tcon' instead of 'con' as variable name:-)
>   
Hows this sample for vfs_cifs?

The bottom fragment is illustrative, this specific file probably won't
need a case statement as the RAW_TCON_TCON max xmit was already filled
in by reply.c

Sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cifs.patch
Type: text/x-diff
Size: 2245 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090508/6198eca6/cifs.bin


More information about the samba-technical mailing list