[PATHC] nested ldb transactions

simo idra at samba.org
Mon Feb 23 11:27:36 MST 2009

On Sun, 2009-02-22 at 02:39 -0500, simo wrote:
> Hi all,
> attached find a patch that would make ldb transactions sane by allowing
> nesting.
> I have not committed it right away because it breaks make test.
> Now, while it is late here and I may be totally drunk and not see the
> evident :-), the only reason why this patch should break anything is
> that transactions have already been used in a sort of nested way, but
> not correctly.

Ok I must indeed have been stupid, as the error was in my patch :-)

> The previous code erroneously committed/canceled any transaction the
> first time ldb_transaction_commit() was called. That means that nested
> transactions were basically broken as an inner transaction would commit
> to the db even if an outer one was not finished.

I am going to commit a revised patch that actually passes tests, and
also fix this problem.


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>

More information about the samba-technical mailing list