[PATHC] nested ldb transactions

Stefan (metze) Metzmacher metze at samba.org
Mon Feb 23 12:06:45 MST 2009


simo schrieb:
> On Sun, 2009-02-22 at 02:39 -0500, simo wrote:
>> Hi all,
>> attached find a patch that would make ldb transactions sane by allowing
>> nesting.
>>
>> I have not committed it right away because it breaks make test.
>>
>> Now, while it is late here and I may be totally drunk and not see the
>> evident :-), the only reason why this patch should break anything is
>> that transactions have already been used in a sort of nested way, but
>> not correctly.
> 
> Ok I must indeed have been stupid, as the error was in my patch :-)
> 
>> The previous code erroneously committed/canceled any transaction the
>> first time ldb_transaction_commit() was called. That means that nested
>> transactions were basically broken as an inner transaction would commit
>> to the db even if an outer one was not finished.
> 
> I am going to commit a revised patch that actually passes tests, and
> also fix this problem.

ok

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090223/297f4d74/signature.bin


More information about the samba-technical mailing list