[PATCH] Add infrastructure for gathering statistics on SMB messages

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Feb 5 21:37:58 GMT 2009

On Thu, Feb 05, 2009 at 11:23:54AM -0800, Tim Prouty wrote:
> >Seems like a legitimate approach - I hope this isn't a condition of
> >patch approval, because I've been working 60 hours a week for a couple
> >of months now, and I'm *still* behind...  2 simultaneous projects to
> >complete + another that is supposed to start yesterday!  Fortunately,
> >its pretty cool cutting edge code.
> I agree that adding a basic profiling module that implements the new  
> statistics API would be a great addition, but I also think it would be  
> good to get the plumbing in now.  As Todd knows very well now, the  
> code in process.c has seen a lot of changes lately, so I would prefer  
> that we get Todd's work integrated, and add a new module as phase 2.   
> Unless there are any objection to the API, I can push it later today.

The problem is -- without a module that we can test against,
it's very likely that changes in process.c or somewhere else
will just break your module again. So you don't really gain
a lot without a sample modules everyone runs.

Don't get me wrong, the interface to me looks really good.
But without having it in a runnable form, it's really hard
to keep it functional.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090205/4dc2e80c/attachment.bin

More information about the samba-technical mailing list