[PATCH] Add infrastructure for gathering statistics on SMB messages

Tim Prouty tprouty at samba.org
Thu Feb 5 19:23:54 GMT 2009

On Feb 5, 2009, at 8:50 AM, Todd Stecher wrote:

>> Another thing: Can you add a module that outputs information
>> similar to the existing profile/ code (not that I have used
>> that in years). If we get that, IMO we could dump the
>> existing stuff and replace it with something actually
>> supported and used. Ideally, this would use the perfmon
>> registry code.
> Seems like a legitimate approach - I hope this isn't a condition of
> patch approval, because I've been working 60 hours a week for a couple
> of months now, and I'm *still* behind...  2 simultaneous projects to
> complete + another that is supposed to start yesterday!  Fortunately,
> its pretty cool cutting edge code.

I agree that adding a basic profiling module that implements the new  
statistics API would be a great addition, but I also think it would be  
good to get the plumbing in now.  As Todd knows very well now, the  
code in process.c has seen a lot of changes lately, so I would prefer  
that we get Todd's work integrated, and add a new module as phase 2.   
Unless there are any objection to the API, I can push it later today.


More information about the samba-technical mailing list