Unable to add posixAccount objectclass to AD user

[brendan powers]

Oops! the previous message was supposed to go directly to Andrew
Bartlett. I would not recommend applying these patches, as it breaks
provisioning. He asked me to send him the patches so he can help me
figure out why.

These patches are intended to fix the improper handling of auxiliary
classes in objectclass.c. The two major changes include reimplementing
objectclass_sort to just sort the classes  by there subClass_order. As
well as using get_last_structural_class to find the class to do the
checks on, instead of the last class in the list. Other changes
include moving get_last_structural_class from descriptor.c to util.c,
and modifying it to ignore auxiliary classes. The check in
password_hash.c was because I tried to create a user that had a
posixAccount, but no user class. This caused a segfault because
io->u.sAMAccountName would be null.

Sorry for the confusion!

On Tue, Dec 8, 2009 at 4:54 PM, Matthias Dieter Wallnöfer <mdw at samba.org> wrote:
> Hi Brendan,
>
> the first thing I suggest is to set the author name and email address on
> your local GIT installation (should be doable through ".gitconfig" in your
> home directory). Otherwise "git-am" formatted patches are nearly useless for
> us.
>
> Then I notice different patches in your attachments which don't fully
> coincide with the email subject ("objectclass" stuff). Therefore it would be
> really helpful for us that you mention your thoughts and reasons about each
> patch in a email (e.g. the "password_hash" module change - why is the check
> for "sAMAccountName" really needed?).
>
> When you are done with this we can start serious discussions about what to
> apply.
>
> Greets,
> Matthias
>
> brendan powers wrote:
>>
>> Here are the patches we discussed.
>>
>
>