Commit: 0920e0b63b806c8ed4839271048dd4924ed02b2b

Kamen Mazdrashki kamenim at gmail.com
Thu Dec 3 19:10:48 MST 2009


Hi Andrew,

On Fri, Dec 4, 2009 at 03:15, Kamen Mazdrashki <kamenim at gmail.com> wrote:
> On Fri, Dec 4, 2009 at 03:08, Andrew Bartlett <abartlet at samba.org> wrote:
>>
>> I still think this is really the wrong approach.  Tridge's code is
>> correct - it uses the correct torture functions to make the temp
>> directory, and uses no environment variables.
>>
>> Instead of reverting, please look carefully at tridge's patch, and
>> simply have it use a different URL when your magic option is et.
>>
>
> Ahh, right, sorry for the noise and thanks for pointing out
> (I was just sitting here and thinking what seems so wrong after
> I did it the way I wanted it) :)
>

Temp directory will be left behind anyway, so why not just leave temp LDB
also. (simple patch attached for this to happen).

Perhaps it will be best in such cases for torture_context to clean up
temp directories created during testing?



-- 
CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-drstest-Don-t-remove-temp-LDB-so-it-can-be-revie.patch
Type: application/octet-stream
Size: 858 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20091204/d1245adf/attachment.obj>


More information about the samba-technical mailing list