Commit: 0920e0b63b806c8ed4839271048dd4924ed02b2b

[Kamen Mazdrashki]

On Fri, Dec 4, 2009 at 03:08, Andrew Bartlett <abartlet at samba.org> wrote:
> On Fri, 2009-12-04 at 02:37 +0200, Kamen Mazdrashki wrote:
>> Hi Tridge,
>>
>>
>> On Sat, Nov 28, 2009 at 07:32,  <tridge at samba.org> wrote:
>> >
>> > no, please don't use an environment variable for this sort of thing.
>> >
>> > If you want to have a way to override the location of this test ldb,
>> > then use lp_parm_string() and then pass the location using the
>> > --option command line option. To see some examples of this, try:
>> >
>> >   git grep lp_parm_string source4/torture/
>> >
>> > for example, you could have:
>> >
>> >   ldb_url = lp_parm_string(tctx->lp_ctx, NULL, "drstest", "ldb_url");
>> >
>> > and then set it with:
>> >
>> >   --option drstest:ldb_url=foo.ldb
>> >
>>
>> Could you please review the attached patches?
>> First one reverts your commit and second uses lp_param_string()
>> instead of getenv("LDB_URL") to find out what temporary ldb_url
>> should be used.
>
> I still think this is really the wrong approach.  Tridge's code is
> correct - it uses the correct torture functions to make the temp
> directory, and uses no environment variables.
>
> Instead of reverting, please look carefully at tridge's patch, and
> simply have it use a different URL when your magic option is et.
>

Ahh, right, sorry for the noise and thanks for pointing out
(I was just sitting here and thinking what seems so wrong after
I did it the way I wanted it) :)


-- 
CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/