348be5f1e44c0 (Share data_blob implementation) breaks Samba3
jelmer at samba.org
Mon Oct 13 03:36:41 GMT 2008
On Mon, 2008-10-13 at 04:55 +0200, Jelmer Vernooij wrote:
> On Sun, 2008-10-12 at 23:23 +0200, Volker Lendecke wrote:
> > On Sun, Oct 12, 2008 at 09:40:19PM +0200, Volker Lendecke wrote:
> > > $SUBJECT says it all. data_blob_string_const() in Samba3
> > > included the terminating NUL, while the new implementation
> > > does not. I am not sure what in Samba4 I break if I just add
> > > the +1. I found it because I get valgrind errors in smbd
> > > now.
> Sorry for breaking this; I must've missed it while comparing the code and
> make test seemed happy. I'll see about using a data_blob_string_const_null() as Jeremy proposes.
I've added a data_blob_string_const_null() and changed the Samba 3 code
to use it. I've also removed the use of "struct data_blob" in the
cluster code, replacing it with DATA_BLOB (which is typedeffed to
It doesn't break "make test", but I'm not sure whether it fixes the
valgrind problems ("make valgrindtest" breaks here because it can't find
libtdb.so.1) or compilation problems with clustering either.
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
More information about the samba-technical