348be5f1e44c0 (Share data_blob implementation) breaks Samba3

Jelmer Vernooij jelmer at samba.org
Mon Oct 13 02:55:42 GMT 2008

Hi Volker, Jeremy,

On Sun, 2008-10-12 at 23:23 +0200, Volker Lendecke wrote:
> On Sun, Oct 12, 2008 at 09:40:19PM +0200, Volker Lendecke wrote:
> > $SUBJECT says it all. data_blob_string_const() in Samba3
> > included the terminating NUL, while the new implementation
> > does not. I am not sure what in Samba4 I break if I just add
> > the +1. I found it because I get valgrind errors in smbd
> > now.
Sorry for breaking this; I must've missed it while comparing the code and
 make test seemed happy. I'll see about using a data_blob_string_const_null() as Jeremy proposes.

> Another one in the same commit: Samba 3 had 'struct data_blob'
> where Samba 4 has 'struct datablob'. This breaks the build
> of the Samba 3 cluster code.
How can I build the cluster code? 


Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org

More information about the samba-technical mailing list