[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3093-g50a347f

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Jul 6 19:24:45 GMT 2008


On Sun, Jul 06, 2008 at 03:05:36PM -0400, simo wrote:
> Found the stuff really difficult to read otherwise.

Yes, I find some code quite hard to read as well, but that's
the penalty for not reviewing code when it is checked in :-)

> Will keep the change local next time, btw if you want to review the
> patch attached to bug 5571, that's why I started reformatting.

Why 

domain[PTR_DIFF(p, domuser)] = 0;

why not just

*p = 0;

This is just a stylistic question, I need to look at the
logic of the code more. I've asked the reporter on irc to
fill in more info how to reproduce the bug.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20080706/dc08c653/attachment.bin


More information about the samba-technical mailing list