[SCM] Samba Shared Repository - branch v3-3-test updated -
idra at samba.org
Sun Jul 6 22:05:46 GMT 2008
On Sun, 2008-07-06 at 21:24 +0200, Volker Lendecke wrote:
> On Sun, Jul 06, 2008 at 03:05:36PM -0400, simo wrote:
> > Found the stuff really difficult to read otherwise.
> Yes, I find some code quite hard to read as well, but that's
> the penalty for not reviewing code when it is checked in :-)
> > Will keep the change local next time, btw if you want to review the
> > patch attached to bug 5571, that's why I started reformatting.
> domain[PTR_DIFF(p, domuser)] = 0;
> why not just
> *p = 0;
> This is just a stylistic question, I need to look at the
> logic of the code more. I've asked the reporter on irc to
> fill in more info how to reproduce the bug.
I guess I was looking at some similar code and just copied it over :)
can be replaced with *p = 0; of course.
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>
More information about the samba-technical