[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3093-g50a347f

[simo]

On Sun, 2008-07-06 at 21:03 +0200, Volker Lendecke wrote:
> Hi, Simo!
> 
> On Sun, Jul 06, 2008 at 11:55:41AM -0500, Simo Sorce wrote:
> > The branch, v3-3-test has been updated
> >        via  50a347f5503ebed0fcc7b9de60f8368677585bb1 (commit)
> >       from  f6c92c4759096f839e3854a1e9eea56e6eecad4d (commit)
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 50a347f5503ebed0fcc7b9de60f8368677585bb1
> > Author: Simo Sorce <idra at samba.org>
> > Date:   Sun Jul 6 12:55:07 2008 -0400
> > 
> >     Clean up winbindd_group.c too
> 
> Why those changes? When your for example look at cc77db2acb
> you will see that I changed only the whitespace only lines
> although other lines in that file would have benefitted from
> reformatting as well. Just reformatting files makes git
> blame a lot harder to read than necessary, so I would like
> to see that if someone reformats, please only the blank
> lines. This does not preclude reformatting changes when you
> have to change logic anyway.

Found the stuff really difficult to read otherwise.
Will keep the change local next time, btw if you want to review the
patch attached to bug 5571, that's why I started reformatting.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>