[SCM] Samba Shared Repository - branch master updated -
4d02bbbfb4d74367bde0f768c02ddb99910ef62d
Jeremy Allison
jra at samba.org
Tue Dec 23 17:19:04 GMT 2008
On Tue, Dec 23, 2008 at 02:31:13AM -0600, Tim Prouty wrote:
> The branch, master has been updated
> via 4d02bbbfb4d74367bde0f768c02ddb99910ef62d (commit)
> from 8ce77a57ccc4d5ff4a216d74c4fc58782fc9098c (commit)
>
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>
>
> - Log -----------------------------------------------------------------
> commit 4d02bbbfb4d74367bde0f768c02ddb99910ef62d
> Author: Tim Prouty <tprouty at samba.org>
> Date: Mon Dec 22 22:35:24 2008 -0800
>
> s3: Fix stream marshalling to return the correct streaminfo status
>
> When there are enough streams on a file to fill up the max_data_count
> when responding to a trans2 streaminfo, samba is returning
> NT_STATUS_BUFFER_TOO_SMALL. Windows handles this by returning
> NT_STATUS_BUFFER_OVERFLOW while still sending as much of the data that
> it can fit into the buffer. When the windows client sees
> BUFFER_OVERFLOW, it retries the streaminfo with a larger buffer (2x).
> The windows client starts at 2K and will continue increasing the
> buffer size by two until it reaches 64K. If the streams don't fit in
> 64K the windows client seems to give up.
>
> This patch fixes marshall_stream_info to overfill the buffer by 1
> stream so that send_trans2_replies can properly detect the overflow
> and return the correct status.
Any chance of a torture test for s4 smbtorture for this Tim ?
That way we'll never regress (hopefully).
Thanks,
Jeremy.
More information about the samba-technical
mailing list