[SCM] Samba Shared Repository - branch master updated - 4d02bbbfb4d74367bde0f768c02ddb99910ef62d

Tim Prouty tprouty at samba.org
Tue Dec 23 19:25:42 GMT 2008

On Dec 23, 2008, at 9:19 AM, Jeremy Allison wrote:

> On Tue, Dec 23, 2008 at 02:31:13AM -0600, Tim Prouty wrote:
>>    This patch fixes marshall_stream_info to overfill the buffer by 1
>>    stream so that send_trans2_replies can properly detect the  
>> overflow
>>    and return the correct status.
> Any chance of a torture test for s4 smbtorture for this Tim ?
> That way we'll never regress (hopefully).

I actually did write one, but ran into a few problems:

1. Samba 4's smbclient was having some issues when receiving a trans2  
response with Data Count equal to the request's Max Data Count.  This  
caused the wrong error message to be passed up to smbtorture.  A  
windows XP client had no problem receiving a response with Data Count  
== Max Data Count, and was able to execute the buffer sizing algorithm  
described in the comment against samba.

2. I may have missed something, but I didn't see a way in Samba 4's  
smbclient to set the Max Data Count.  It appears to be hard coded to  
64K.  This prevented me from writing a torture test that really  
reproduces what the windows client does.

I didn't spend too much time tinkering with samba 4's smbclient, but  
if anyone is interested in looking, I attached the test.  I'll try and  
get to it after I get a few other higher priority items done.

Jeremy, speaking of RAW-STREAMS torture, how is the rename fix going?   
I also wrote a rename torture test last week to reproduce that exact  
bug :).  I was about to get started on writing a fix when I saw that  
you already wrote one :).  Once you get RAW-STREAMS passing again,  
I'll push any additions I have in my rename test.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-torture-Add-large-streaminfo-buffer-torture-test.patch
Type: application/octet-stream
Size: 3249 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20081223/68584e78/0001-s4-torture-Add-large-streaminfo-buffer-torture-test.obj
-------------- next part --------------

More information about the samba-technical mailing list