svn commit: samba r24968 - in branches/SAMBA_3_2_0/source:
include libsmb
simo
idra at samba.org
Fri Sep 7 12:39:38 GMT 2007
On Thu, 2007-09-06 at 23:33 -0400, Derrell Lipman wrote:
> On 9/6/07, Andrew Bartlett <abartlet at samba.org> wrote:
> >
> > Or rename the structure members, if possible?
>
> No can do. Those names are part of the exposed interface. I had
> always wanted, however, to change the code to use the formal (and
> strictly correct) parenthesis around the entire function pointer, so
> this was my opportunity. I checked in that change shortly after
> receiving Simo's response. As long as the macro doesn't break that
> (it better not, or a whole lot of applications will break), then we're
> cool as far as libsmbclient goes.
Derrell, your fix is correct, and we don't need anything else, macros
don't kick in with the strict (and standards compliant) syntax.
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org
More information about the samba-technical
mailing list