[PATCH] 2/2: Associate file locations to newly introduced path variables

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christian,

> The point is doing the following associations:
> 
> - discardable cache data (browse.dat, printers.tbd, <printer>.tdb...)
>   go to cachedir
> - non discardable state data (all TDB files that may need to be backed
>   up) go to statedir
> - shared data (codepage stuff) go to codepagedir
> 
....
>  
> @@ -66,7 +66,7 @@
>             winbindd_cache.tdb open.  Open the tdb if a NULL is passed. */
>  
>  	if (!tdb) {
> -		tdb = tdb_open_log(lock_path("winbindd_cache.tdb"), 
> +		tdb = tdb_open_log(cache_path("winbindd_cache.tdb"), 
>  				   WINBINDD_CACHE_TDB_DEFAULT_HASH_SIZE,
>  				   TDB_DEFAULT, O_RDWR, 0600);
....
> -	cache_fname = lock_path("idmap_cache.tdb");
> +	cache_fname = cache_path("idmap_cache.tdb");
>  
>  	DEBUG(10, ("Opening cache file at %s\n", cache_fname));


We've had this discussion before and your patch still suffers
from the same assumptions.  Tdb files may operate as both
cache and persistent state.  For example, the idmap_cache.tdb
and winbindd_cache.tdb are required for offline logons.

If you remove the $(lockdir)/printing/*tdb, an print jobs sent
by Windows clients that are held in the print queue after a reboot
will now appear as "Remote Downlevel Document".

I can give you the data_path() changes.  But -1 on the state and cache
path separation.  FHS-compliant or not, in this respect, the Debian
packages break Samba functionality.





cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHE/gDIR7qMdg1EfYRAkNZAKDsyuuOSO4h1r2uE9lHTd15mh++qQCg7rse
2a/61ygqmIaElK+w5F/mQGw=
=cIZW
-----END PGP SIGNATURE-----