[PATCH] 2/2: Associate file locations to newly introduced path
vorlon at debian.org
Wed Oct 17 09:03:05 GMT 2007
On Sun, Oct 14, 2007 at 04:56:42PM +0200, Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Christian Perrier schrieb:
> > This patch switches the 3.2.0pre1 sources to use newly introduced variables in
> > fhs-newpaths.patch.
> I just looked shortly over your 2 patches, and my first impression
> is the patch looks nice, I just didn't like the +#ifdef FHS_COMPATIBLE.
> And I can't thin kof a reason why this is needed at all...
The #ifdef FHS_COMPATIBLE bits from the second patch don't belong here at
all, they're part of the (inelegant) changes to the actual directory values
(the third, not-submitted patch).
The FHS_COMPATIBLE bits in fhs-newpaths.patch, I'm happy to discuss. But
basically, the reason they're there in the first place is that - as hinted
at in the second patch - we're currently breaking the 'lock dir' smb.conf
option in order to enable FHS compatibility without implementing new
Debian-specific options with complicated semantics. If the option of full
FHS support were adopted upstream, I'm sure we could reach a much better
technical solution for handing configurability of path options.
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
vorlon at debian.org http://www.debian.org/
More information about the samba-technical