[PATCH] Add stackframes to public libsmbclient functions
ab at samba.org
Tue Nov 20 06:55:31 GMT 2007
> On Mon, 2007-11-19 at 15:37 +0100, Volker Lendecke wrote:
>> On Mon, Nov 19, 2007 at 09:25:35AM -0500, Derrell Lipman wrote:
>>> of the lower-level function that there's a problem down below.
>>> That's not the way to do it IMO.
>> Sad. Then we have to remove talloc_stackframe() completely again. I
>> pretty much liked it, but as Simo has also already reject it, we
>> probably need to remove them :-(
> Volker, I am ok with stackframe the only thing I don't digest yet is
> the use of an implicit destructor (can be replaced in theory) but
> samba3 code never uses destructors so I am ok with its use
DBWRAP code in Samba 3 uses destructors, see
source/lib/dbwrap_tdb.c:db_tdb_record_destr(). It even allocates childs
in destructor in relies on 'childs freed after calling destructor'
/ Alexander Bokovoy
Samba Team http://www.samba.org/
ALT Linux Team http://www.altlinux.org/
Midgard Project Ry http://www.midgard-project.org/
More information about the samba-technical