[PATCH] Add stackframes to public libsmbclient functions

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Nov 20 07:55:34 GMT 2007


On Tue, Nov 20, 2007 at 09:55:31AM +0300, Alexander Bokovoy wrote:
> >Volker, I am ok with stackframe the only thing I don't digest yet is
> >the use of an implicit destructor (can be replaced in theory) but
> >samba3 code never uses destructors so I am ok with its use
> DBWRAP code in Samba 3 uses destructors, see
> source/lib/dbwrap_tdb.c:db_tdb_record_destr(). It even allocates childs
> in destructor in relies on 'childs freed after calling destructor'
> semantics.

If all of you are against this construct, why can't you
comment on it when I checked it in in the first place? Now
it is going to be a fucking hell lot of work to remove it
all again!!

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20071120/3088e4c5/attachment.bin


More information about the samba-technical mailing list