[PATCH] Add stackframes to public libsmbclient functions

simo idra at samba.org
Mon Nov 19 16:35:27 GMT 2007

On Mon, 2007-11-19 at 15:37 +0100, Volker Lendecke wrote:
> On Mon, Nov 19, 2007 at 09:25:35AM -0500, Derrell Lipman wrote:
> > of the lower-level function that there's a problem down below.  That's
> > not the way to do it IMO.
> Sad. Then we have to remove talloc_stackframe() completely
> again. I pretty much liked it, but as Simo has also already
> reject it, we probably need to remove them :-(

Volker, I am ok with stackframe
the only thing I don't digest yet is the use of an implicit destructor
(can be replaced in theory)
but samba3 code never uses destructors so I am ok with its use

> This will introduce tons of additional talloc_ctx arguments,
> in particular the DEBUG message arguments will become quite
> difficult to code. But going back to static pstrings is not
> an option in my opinion.

I think smaller patches will make it more digestable :-)


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>

More information about the samba-technical mailing list