svn commit: samba r22713 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

[simo]

On Sun, 2007-05-06 at 20:29 -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Simo,
> 
> > You basically reverted some code you already committed 
> > and I changed in 3_0_25. Right now each single backend
> > init function can cope with the offline mode. Each one
> > has a delayed initialization mode, so point (c)
> > should not be needed.
> 
> but it is and it now works completely.  Give me another
> day to finish testing the merge.
> 
> > The query code should also be able to cope with 
> > offline requests, that's the whole point of returning
> > ID_EXPIRED, so that in case we can't really
> > resolve we keep it, otherwise we get the correct return.
> 
> No.  The backend should never be hit at all when
> in offline mode.  That it the point of having the cache.

Yes, the cache should help, but there are still some backends that can
safely be queried when offline.

> This way the local and remote backends work the
> same way.  You don't want to allocate ids in offline mode
> as you are not always able to validate the SID.

In fact you shouldn't allocate if you are not able to validate the SID.
When offline allocation functions should probably not be called
(previously the validation code was in idmap so it was easy to avoid
problems ...)

> 
> > Basically the problem of avoiding the query completely 
> > is that you also avoid querying
> > idmap_tdb/idmap_rid/idmap_passdb/idmap_nss.
> > they all the mappings and can be consulted when offline
> > without problems.
> 
> true.  I'll continue to revisit this.  But things were
> not working an now they are.  I don't want to have different
> backends working in different ways and require each backend
> to be debugged for offline mode individually.
> 
> Just give me another day pleas and we can then discuss
> it more.  Thanks

Sure, np.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org