svn commit: samba r23312 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

jpeach at samba.org wrote:

> Author: jpeach
> Date: 2007-06-02 21:12:47 +0000 (Sat, 02 Jun 2007)
> New Revision: 23312
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=23312
> 
> Log:
> As per Volker, rename the "windbind:ads" parameter "winbind:rpc only".
...
> @@ -171,7 +170,7 @@
>  
>  		if ((our_domain->active_directory || IS_DC)
>  		    && domain->active_directory
> -		    && lp_parm_bool(-1, "winbind", "ads", True)) {
> +		    && !lp_parm_bool(-1, "winbind", "rpc only", False)) {
>  			DEBUG(5,("get_cache: Setting ADS methods for domain %s\n", domain->name));
>  			domain->backend = &ads_methods;


James,

I know that I've only had one cup of coffee but this
logic looks wrong.  Looks double negated to me.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGYrvzIR7qMdg1EfYRAuf6AJwMPglZcMPr7oE5LyCnd+yZfWFqvACgnBY+
zFU0nFHh6tGHOvour3Pv1j0=
=wB85
-----END PGP SIGNATURE-----