svn commit: samba r23312 - in branches: SAMBA_3_0/source/nsswitch SAMBA_3_0_26/source/nsswitch

[James Peach]

On 03/06/2007, at 6:02 AM, Gerald (Jerry) Carter wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> jpeach at samba.org wrote:
>
>> Author: jpeach
>> Date: 2007-06-02 21:12:47 +0000 (Sat, 02 Jun 2007)
>> New Revision: 23312
>>
>> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi? 
>> view=rev&root=samba&rev=23312
>>
>> Log:
>> As per Volker, rename the "windbind:ads" parameter "winbind:rpc  
>> only".
> ...
>> @@ -171,7 +170,7 @@
>>
>>  		if ((our_domain->active_directory || IS_DC)
>>  		    && domain->active_directory
>> -		    && lp_parm_bool(-1, "winbind", "ads", True)) {
>> +		    && !lp_parm_bool(-1, "winbind", "rpc only", False)) {
>>  			DEBUG(5,("get_cache: Setting ADS methods for domain %s\n",  
>> domain->name));
>>  			domain->backend = &ads_methods;
>
>
> James,
>
> I know that I've only had one cup of coffee but this
> logic looks wrong.  Looks double negated to me.

I might have misunderstood this. The sense of "winbind: rpc only" is  
the opposite of the sense of "winbind:ads", hence the negation. So  
"winbind: rpc only = yes" should force LDAP off, which means that not 
("winbind:rpc only = yes") should let us do LDAP if we were already  
planning on doing it.

This sense of the parameter makes the login of the code a little  
harder, but IMHO it's a lot more obvious for admins. We can probably  
refactor the conditional her to make the code more obvious as well.

--
James Peach | jpeach at samba.org