[SAMBA4][PATCH] separate srcdir and builddir (version 2)

[James Peach]

On Jan 9, 2007, at 2:58 AM, Stefan (metze) Metzmacher wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> James Peach schrieb:
>> Hi all,
>>
>> The attached patch alters the Samba4 buildsystem to allow separate  
>> build
>> and source directories. This version fixes the "installheaders" and
>> "test" targets.
>>
>> Please test it out. It works for me (tm). I'd definitely appreciate
>> comments from people more familiar with the build system.
>
> I have some comments and questions:
>
> 1.) why the change related to the visibility?

It doesn't need to be a AC_TRY_RUN, AC_TRY_LINK should be sufficient  
for this test. I do a cross-compile to build multi-way binaries on OS  
X, so this hunk leaked into the patch from there. You are right, it's  
not related to the srcdir/builddir portions.

> 2.) could you split this patch a bit, I like the splitting out
>     as the compile commands into make variables, but it seems to be  
> not
>     related directly with srcdir != builddir. Can you commit this
>     standalone first, as it's just one to one copying, without  
> changing
>     logic.

I did it this way in preference to adding $(srcdir) a lot of times. I  
could split this into a separate patch, though.

> 3.) there're some debugging related changes left in the patch...

Hmmm. I just checked quickly and didn't see what you are referring to.  
The changes in config_mk.pm to emit makefile comments are deliberate,  
and I'd like to keep them.

> 4.) about the $* vs. $< change, we should somehow try to set the  
> COMPILE
>     variable to only use $<, when srcdir != builddir, so that srcdir  
> ==
>     builddir still works on bsd boxes.

Maybe. I don't know of a portable way to do conditionals across make  
variants.

> The rest looks ok (I assume you have well tested srcdir != builddir
> _and_ srcdir == buildir cases:-)
>
> metze
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2 (GNU/Linux)
> Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
>
> iD8DBQFFo3U7m70gjA5TCD8RAoyDAJ9MLHHc6dkFE5wJAPLb3/mxiWXlqACgniN+
> C5mVKjXrRjn/1IUantu4EtE=
> =ShTG
> -----END PGP SIGNATURE-----

--
James Peach | jpeach at samba.org