[SAMBA4][PATCH] separate srcdir and builddir (version 2)
Stefan (metze) Metzmacher
metze at samba.org
Tue Jan 9 10:58:04 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
James Peach schrieb:
> Hi all,
> The attached patch alters the Samba4 buildsystem to allow separate build
> and source directories. This version fixes the "installheaders" and
> "test" targets.
> Please test it out. It works for me (tm). I'd definitely appreciate
> comments from people more familiar with the build system.
I have some comments and questions:
1.) why the change related to the visibility?
2.) could you split this patch a bit, I like the splitting out
as the compile commands into make variables, but it seems to be not
related directly with srcdir != builddir. Can you commit this
standalone first, as it's just one to one copying, without changing
3.) there're some debugging related changes left in the patch...
4.) about the $* vs. $< change, we should somehow try to set the COMPILE
variable to only use $<, when srcdir != builddir, so that srcdir ==
builddir still works on bsd boxes.
The rest looks ok (I assume you have well tested srcdir != builddir
_and_ srcdir == buildir cases:-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical