svn commit: samba r18567 - in branches/SAMBA_4_0/source/scripting/libjs: .

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

tridge at samba.org wrote:
> Jerry,
> 
>  > > When changing a field name in idl, please remember to check for use of
>  > > those functions in any js code as well.
>  > 
>  > So what needs to be run other than 'make'?
> 
> There are two ways to find all the places that need changing. 

ACK.

> You can also just run 'make test', and in this case 
> that did show a failure as winreg.js is tested quite
> well, but I agree with your comment on IRC that a
> test failure isn't as obvious as it could be. If
> you don't want to scroll through all the 
> output then you would have needed to notice the
> "TEST STATUS: N" at the end where "N" is not
> equal to zero. I've now changed that to give 
> a nice big "TESTSUITE FAILED" message with lots
> of ascii-art emphasis around it :-)

Cool.  Thanks.  And sorry for the breakage.  I've branched
the IDL files to bzr tree so I can play more without affecting
the SAMBA_4_0 dev tree.





cheers, jerry



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFC18CIR7qMdg1EfYRAvPCAJ9M+vvQzoPq3JFxKfSQUgSIMTQ+tACgkQu4
YoTCt5Z0oiehb8M86VP8Zss=
=O1ut
-----END PGP SIGNATURE-----