code formatting [ was Re: svn commit: samba r13292 ]

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Volker Lendecke wrote:
> On Thu, Feb 02, 2006 at 08:23:28PM +0000, jra at samba.org wrote:
>> Rather a big patch I'm afraid, but this should fix bug #3347
>> by saving the UNIX token used to set a delete on close flag,
>> and using it when doing the delete. libsmbsharemodes.so still
>> needs updating to cope with this change.
>> Samba4 torture tests to follow.
> 
> One thing I kind of don't like about this patch is partly 
> cosmetics. It's very hard to find the functional change in this
> patch because it has some little functional stuff intermixed with a
< huge amount of pure reformatting and addan indirection in
> the current_user struct.

Can I just suggest that when someone needs to reformat, you do not do it
manually.  There is an source/.indent.pro file both in trunk and
SAMBA_3_0.  Simply run the file through indent (the rc file is pretty
close to our current code formatting conventions) and check it in.

You and jra seem to have differing formatting conventions which
pull at each other.  And I'm not coming down on either side of
the 80 char column debate.




cheers, jerry
=====================================================================
I live in a Reply-to-All world.               -----------------------
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFD4n4AIR7qMdg1EfYRAs9UAJ9MWwwmJxn4RcHn6Sfq3KC9adKsmACfRNn+
9jkOg+Em+U6TNoDJHkkrlJQ=
=RtAu
-----END PGP SIGNATURE-----