speeding up string_to_sid
jra at samba.org
Thu Oct 20 16:54:34 GMT 2005
On Thu, Oct 20, 2005 at 09:45:40AM -0500, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Jim McDonough wrote:
> > We've got a customer hitting the CPU wall on winbind, and a big
> > factor in it is the string_to_sid() code
> > So for a million lookups, that's the difference. And this customer is
> > getting a tremendous rate of lookups...
> > Think i should check this in? Or some variant?
> The patch looks good to me. If you could s/memset/ZERO_STRUCTP/
> and then fix the outdated comments to 'ia', that would be good.
Likewise (looks good) - ship it Jim !
More information about the samba-technical