svn commit: samba r11224 - branches/SAMBA_3_0/source/script trunk/source/script

Gerald (Jerry) Carter jerry at samba.org
Thu Oct 20 14:30:54 GMT 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

lmuelle at samba.org wrote:
> Author: lmuelle
> Date: 2005-10-20 12:58:40 +0000 (Thu, 20 Oct 2005)
> New Revision: 11224
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11224
> 
> Log:
> Add feature to get our configuration from config.log into installman.sh.
> This allows us to install for example smbsh.1 only if SMBWRAPPER is set.
> 
> Removed also one rm call as we copy and do not append to the same file
> in the next step.  There is no file permission risk as we chmod 0644 in
> any case later.
> 
> Replaced one basename call by shell substitution.

Lars,

Can't we just get the information from 'smbd -b'?  My guess is
that the format of config.log will change over time with new
autoconf releases.  This patch seems really fragile to me.
And it's pretty hard to read as well.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDV6oeIR7qMdg1EfYRAuhZAJ9fUY+I8KSr0Bl2n15TZhfr08uvlwCgvr8F
2Z1/y8yqhrPLot512xDY538=
=te4P
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list