speeding up string_to_sid

Gerald (Jerry) Carter jerry at samba.org
Thu Oct 20 14:45:40 GMT 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim McDonough wrote:
> We've got a customer hitting the CPU wall on winbind, and a big 
> factor in it is the string_to_sid() code
...
> So for a million lookups, that's the difference.  And this customer is 
> getting a tremendous rate of lookups...
> 
> Think i should check this in?  Or some variant?

The patch looks good to me.  If you could s/memset/ZERO_STRUCTP/
and then fix the outdated comments to 'ia', that would be good.






cheers, jerry
=====================================================================
Alleviating the pain of Windows(tm)      ------- http://www.samba.org
GnuPG Key                ----- http://www.plainjoe.org/gpg_public.asc
"There's an anonymous coward in all of us."               --anonymous
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDV62TIR7qMdg1EfYRAseVAJ490wddMYBgd2Y/CZpAzYtqVmG0gACfaSCd
AODbsvqY1w1ikdO+1y+JkSI=
=rdio
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list